[webkit-reviews] review requested: [Bug 87873] [chromium] Single thread proxy should not tick animations unless the layer renderer has been initialized : [Attachment 144886] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 87873: [chromium] Single thread proxy should not tick animations unless the
layer renderer has been initialized
https://bugs.webkit.org/show_bug.cgi?id=87873

Attachment 144886: Patch
https://bugs.webkit.org/attachment.cgi?id=144886&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #5)
> (From update of attachment 144875 [details])
> This still feels fishy - nobody should be calling initializeLayerRenderer()
if we returned false.  Where's this call coming from?
Someone started the animation timer before the layer renderer was initialized,
and when it fires we land in this code.
If the CCSingleThreadProxy is destroyed, then this timer is stopped, but it
doesn't seems like that's happening, so I've
put guard code in the timer callback to ensure that we only tick if we've got
an initialized layer renderer.