[webkit-reviews] review granted: [Bug 87829] [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument : [Attachment 144828] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 87829: [EFL] Ewk_Intent_Request's postResult/postFailure should take
serialized script values in argument
https://bugs.webkit.org/show_bug.cgi?id=87829

Attachment 144828: Patch
https://bugs.webkit.org/attachment.cgi?id=144828&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144828&action=review


> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:676
> +	   ewk_intent_request_failure_post(request,
WebCore::SerializedScriptValue::create(String::fromUTF8("ERROR")));

Should we send a serialization of null instead?  It seems strange to have this
hard-coded error string.