[webkit-reviews] review requested: [Bug 87873] [chromium] Single thread proxy should not release its context prematurely : [Attachment 144875] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 87873: [chromium] Single thread proxy should not release its context
prematurely
https://bugs.webkit.org/show_bug.cgi?id=87873

Attachment 144875: Patch
https://bugs.webkit.org/attachment.cgi?id=144875&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #3)
> (In reply to comment #0)
> > Currently, in CCSingleThreadProxy::initializeLayerRenderer(), the reference
to m_contextBeforeInitialization is released and passed to
m_layerTreeHostImpl->initializeLayerRenderer(...), but if that call fails, then
m_contextBeforeInitialization is null, so subsequent calls to
CCSingleThreadProxy::initializeLayerRenderer() will cause a crash. It is
reasonable to retry initialization, because it can fail due to memory issues
that may eventually be resolved.
>
> The embedder should decide to retry by passing in a new context, the
compositor shouldn't attempt to retry with the existing context.
Sg. If we fail with the first context. We won't try with it again.