[webkit-reviews] review denied: [Bug 87842] [WK2-Gtk]Compilation errors with flag CONTEXT_MENUS=0 : [Attachment 144779] fix

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied chandra shekar vallala
<chandra.vallala at motorola.com>'s request for review:
Bug 87842: [WK2-Gtk]Compilation errors with flag CONTEXT_MENUS=0
https://bugs.webkit.org/show_bug.cgi?id=87842

Attachment 144779: fix
https://bugs.webkit.org/attachment.cgi?id=144779&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144779&action=review


Looks good, but I don't think you're a committer, so r- for some minor issues.

> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:30
> +
> +#if ENABLE(CONTEXT_MENUS)
> +
>  #include "WebContextMenuProxyGtk.h"

See below.

> Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:30
>  #include "config.h"
> +
> +#if ENABLE(CONTEXT_MENUS)
> +

WebContextMenuClient.h already seems to be guarded by ENABLE(CONTEXT_MENUS) so
you can move the #ifdef down before the second block.