[webkit-reviews] review denied: [Bug 72099] [WK2] Keyboard menu key should show context menu : [Attachment 144798] updated-patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied chandra shekar vallala
<chandra.vallala at motorola.com>'s request for review:
Bug 72099: [WK2] Keyboard menu key should show context menu
https://bugs.webkit.org/show_bug.cgi?id=72099

Attachment 144798: updated-patch
https://bugs.webkit.org/attachment.cgi?id=144798&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144798&action=review


Looks alright apart from a few small issues. r- because of the build break
though.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:468
> +    WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(widget);
> +    WebKitWebViewBasePrivate* priv = webViewBase->priv;
> +#if ENABLE(CONTEXT_MENUS)
> +    priv->pageProxy->handleContextMenuKeyEvent();
> +#endif // ENABLE(CONTEXT_MENUS)

I think it makes sense to just write:

#if ENABLE(CONTEXT_MENUS)
WEBKIT_WEB_VIEW_BASE(widget)->priv->pageProxy->handleContextMenuKeyEvent();
#endif

Shouldn't you return true here in side the #ifdef?