[webkit-reviews] review requested: [Bug 87510] [chromium] create WebTransformOperation interface for chromium platform : [Attachment 144848] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 87510: [chromium] create WebTransformOperation interface for chromium
platform
https://bugs.webkit.org/show_bug.cgi?id=87510

Attachment 144848: Patch
https://bugs.webkit.org/attachment.cgi?id=144848&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #8)
> (From update of attachment 144355 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=144355&action=review
>
> > Source/Platform/chromium/public/WebTransformOperations.h:43
> > +	 WEBKIT_EXPORT WebTransformOperations();
>
> it's a bit atypical to have exported c'tors / d'tors in the WebKit API - see
"Methods" in http://trac.webkit.org/wiki/ChromiumWebKitAPI.  It's more typical
to have inline c'tors that call exported functions if necessary
Done.
>
> > Source/Platform/chromium/public/WebTransformOperations.h:46
> > +	 // Not virtual. Should not be subclassed.
>
> This comment isn't really necessary, IMO
Removed.
>
> > Source/Platform/chromium/public/WebTransformOperations.h:75
> > +	 enum Type {
>
> See "Enums" in http://trac.webkit.org/wiki/ChromiumWebKitAPI
Fixed.