[webkit-reviews] review granted: [Bug 87799] Implement CSSParser::determineNameInNamespace() as a helper function for CSSGrammar.y : [Attachment 144663] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kentaro Hara <haraken at chromium.org>'s
request for review:
Bug 87799: Implement CSSParser::determineNameInNamespace() as a helper function
for CSSGrammar.y
https://bugs.webkit.org/show_bug.cgi?id=87799

Attachment 144663: Patch
https://bugs.webkit.org/attachment.cgi?id=144663&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144663&action=review


> Source/WebCore/css/CSSGrammar.y:960
> +	   $$->setTag(p->determineNameInNamespace(namespacePrefix, $2));

We should get rid of the namespacePrefix local variable and just use $1 here.

> Source/WebCore/css/CSSGrammar.y:1089
> +	   $$->setAttribute(p->determineNameInNamespace(namespacePrefix, $4));

Same with $3 here.

> Source/WebCore/css/CSSGrammar.y:1096
> +	   $$->setAttribute(p->determineNameInNamespace(namespacePrefix, $4));

Same with $3 here.