[webkit-reviews] review granted: [Bug 74111] Some overlay scrollbar API calls in ScrollAnimatorMac can lead to an assertion in RenderBox::mapAbsoluteToLocalPoint : [Attachment 144815] Fix + manual test that asserts

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 74111: Some overlay scrollbar API calls in ScrollAnimatorMac can lead to an
assertion in RenderBox::mapAbsoluteToLocalPoint
https://bugs.webkit.org/show_bug.cgi?id=74111

Attachment 144815: Fix + manual test that asserts
https://bugs.webkit.org/attachment.cgi?id=144815&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144815&action=review


> ManualTests/scrollbar-crash-on-hide-scrolled-area.html:5
> +    <meta charset="utf-8"/>
> +    <title>QuickStart</title>

Neither seem necessary

> ManualTests/scrollbar-crash-on-hide-scrolled-area.html:33
> +    <br /><br /><br />Manual repro: scroll down and click on <b>Next
step</b><br /><br /><br /><br /><br /><br />
> +    <br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br
/><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br />
> +    <br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br
/><br /><br /><br /><br /><br /><br />
> +    <br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br
/><br /><br /><br /><br /><br /><br /><br /><br /><br />
> +    <br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br
/><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br />
> +    <br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br
/><br /><br /><br /><br /><br /><br /><br /><br /><br />
> +    <br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br /><br />


Ick. Can this testase be simplified, maybe by just adding css height to an
element?