[webkit-reviews] review granted: [Bug 87851] [Qt] ImageDecoderQt doesn't support some decoders : [Attachment 144806] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Allan Sandfeld
Jensen <allan.jensen at nokia.com>'s request for review:
Bug 87851: [Qt] ImageDecoderQt doesn't support some decoders
https://bugs.webkit.org/show_bug.cgi?id=87851

Attachment 144806: Patch
https://bugs.webkit.org/attachment.cgi?id=144806&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144806&action=review


> Source/WebCore/ChangeLog:4
>  
> +	   [Qt] ImageDecoderQt doesn't support some decoders.
> +	   https://bugs.webkit.org/show_bug.cgi?id=87851

More info about which?

> Source/WebCore/platform/graphics/qt/ImageDecoderQt.cpp:161
> +    // We don't need the tables set by prepareScaleDataIfNecessary, but
their dimensions
> +    // are used by ImageDecoder::scaledSize().

Can we split those lines more equally

// We don't need the tables set by prepareScaleDataIfNecessary, but
// their dimensions are used by ImageDecoder::scaledSize().