[webkit-reviews] review granted: [Bug 87644] Web Inspector: Option for selecting/deselecting all breakpoints in breakpoint pane : [Attachment 144728] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted sam <dsam2912 at gmail.com>'s
request for review:
Bug 87644: Web Inspector: Option for selecting/deselecting all breakpoints in
breakpoint pane
https://bugs.webkit.org/show_bug.cgi?id=87644

Attachment 144728: Patch
https://bugs.webkit.org/attachment.cgi?id=144728&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144728&action=review


Coul

> Source/WebCore/inspector/front-end/BreakpointManager.js:141
> +    // select all breakpoints which are not enabled(un-checked). 

Please remove this comment it doesn't add anything to the code.

> Source/WebCore/inspector/front-end/BreakpointManager.js:152
> +    // deselect all breakpoints which are enabled(checked). 

Please remove this comment it doesn't add anything to the code.

> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:178
> +	   // Get the count for checked breakpoints.

Please remove the comment.

> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:192
> +	       contextMenu.appendItem(WebInspector.UIString("Select All
Breakpoints"),
this._breakpointManager.selecAllBreakpoints.bind(this._breakpointManager));

You might want to hide this item if there is only one breakpoint.

> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:196
> +	       contextMenu.appendItem(WebInspector.UIString("Select All
Breakpoints"),
this._breakpointManager.selecAllBreakpoints.bind(this._breakpointManager));

Could you change "Remove All JavaScript Breakpoints" title above to "Remove All
Breakpoints" so that they are all stick to the same style?