[webkit-reviews] review denied: [Bug 87337] [Blackberry] WebKit's fullscreen mode needs to notify page client. : [Attachment 144780] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied Chris.Guan
<chris.guan at torchmobile.com.cn>'s request for review:
Bug 87337: [Blackberry] WebKit's fullscreen mode needs to notify page client.
https://bugs.webkit.org/show_bug.cgi?id=87337

Attachment 144780: Patch
https://bugs.webkit.org/attachment.cgi?id=144780&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144780&action=review


> Source/WebKit/blackberry/Api/WebPage.cpp:6061
> +    // Search for a video element in this document.
> +    Document* document = frame->document();
> +    for (Node* node = document->firstChild(); node; node =
node->traverseNextNode(document)) {
> +	   if (!node->isElementNode())
> +	       continue;
> +	   if (node->hasTagName(HTMLNames::videoTag))
> +	       return true;
> +    }
> +
> +    // Do the same for the nested frames.
> +    for (Frame* child = frame->tree()->firstChild(); child; child =
child->tree()->nextSibling()) {
> +	   if (containsVideoTags(child))
> +	       return true;

that can be VERY slow. r- due to that.

> Source/WebKit/blackberry/Api/WebPage.cpp:6082
> +#if ENABLE(VIDEO)

can you have #fullscreen_api enabled and #video disabled?