[webkit-reviews] review requested: [Bug 85856] [Chromium] Cannot show the left side of an RTL element with a vertical scrollbar : [Attachment 144772] Patch v4 (added another test)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 30 02:45:02 PDT 2012


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 85856: [Chromium] Cannot show the left side of an RTL element with a
vertical scrollbar
https://bugs.webkit.org/show_bug.cgi?id=85856

Attachment 144772: Patch v4 (added another test)
https://bugs.webkit.org/attachment.cgi?id=144772&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,

I have added a layout test to test this change works with the vertical-writing
mode.
By the way, to investigate failing tests, the following tests (028.html,
unreachable-overflow-rtl.html, 026.html) cannot show the left sides of RTL
elements exactly due to this issue. (That is, this change fixed rendering
problems of these tests and needs to rebaseline them.)
  fast/block/float/028.html
  fast/overflow/unreachable-overflow-rtl-bug.html
  fast/block/float/026.html
On the other hand, 'offsetX-offsetY.html' sends mouse events to scrollbars and
it fails when a vertical scrollbar is shown at the left side. (That is, we need
to change the test itself.)
  fast/events/offsetX-offsetY.html
Does this change need to include rebaselined results and test fixes?

Regards,

Hironori Bono


More information about the webkit-reviews mailing list