[webkit-reviews] review granted: [Bug 83693] [EFL][WK2] Fix WebKit2-EFL build : [Attachment 144572] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 83693: [EFL][WK2] Fix WebKit2-EFL build
https://bugs.webkit.org/show_bug.cgi?id=83693

Attachment 144572: Patch
https://bugs.webkit.org/attachment.cgi?id=144572&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144572&action=review


Looks good, just a couple of things you can change before landing.

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:66
> +#if ENABLE(INPUT_TYPE_COLOR)
> +#include "ColorChooser.h"
> +#endif
> +

Use #include <WebCore/ColorChooser.h> like all other webcore headers in this
file. You don't need the #if ENABLE(INPUT_TYPE_COLOR) because the header is
already protected by that check. Remember to move the header to keep all
headers sorted alpahbetically

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:78
> +#if ENABLE(WEB_INTENTS)
> +#include "IntentRequest.h"
> +#endif

And same here for IntentRequest.h