[webkit-reviews] review requested: [Bug 80400] [Qt] Set WebCore imagedecoders as default, add fallback to QImageDecoder : [Attachment 144737] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 30 00:46:05 PDT 2012


Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 80400: [Qt] Set WebCore imagedecoders as default, add fallback to
QImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=80400

Attachment 144737: proposed patch
https://bugs.webkit.org/attachment.cgi?id=144737&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
(In reply to comment #29)

> Sounds good, but isn't it a very short distance from here to taking the
result from the configure test, turning it into a HAVE(LIBPNG) (or something)
and use that instead of #if OS(WIN)?

Done. :)

Ossy tested the patch on windows for me and I tested it on mac, with qt5 and
with 4.8.


More information about the webkit-reviews mailing list