[webkit-reviews] review granted: [Bug 84551] CSS3 calc: Implement CSSOM support : [Attachment 144714] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Mike Lawther
<mikelawther at chromium.org>'s request for review:
Bug 84551: CSS3 calc: Implement CSSOM support
https://bugs.webkit.org/show_bug.cgi?id=84551

Attachment 144714: Patch
https://bugs.webkit.org/attachment.cgi?id=144714&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144714&action=review


> Source/WebCore/css/CSSCalculationValue.cpp:82
> +    if (expression[0] != '(')
> +	   result.append('(');

(In reply to comment #6)
> The only time we need the extra brackets is when there is only a single term
in the expression, eg "100px" will come out as "100px".

It would be good to codify this information. e.g.
bool expressionHasSingleTerm = expression[0] != '(';
if (expressionHasSingleTerm)
...