[webkit-reviews] review denied: [Bug 87578] [FileAPI] The result attribute of FileReader shuold use null to replace empty string : [Attachment 144686] Patch

[bugzilla-daemon at webkit.org]

Jian Li <jianli at chromium.org> has denied Li Yin <li.yin at intel.com>'s request
for review:
Bug 87578: [FileAPI] The result attribute of FileReader shuold use null to
replace empty string
https://bugs.webkit.org/show_bug.cgi?id=87578

Attachment 144686: Patch
https://bugs.webkit.org/attachment.cgi?id=144686&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144686&action=review


> Source/WebCore/ChangeLog:10
> +	   Or if an error in reading the File or Blob has occurred (using any
read method),

nit: two "if" can be concatenated like If the readyState is EMPTY (...) or an
error occurs ...

> Source/WebCore/ChangeLog:17
> +

nit: extra empty line is not needed.

> LayoutTests/fast/files/resources/read-file-test-cases.js:221
> +    log("result before calling reading method: " +
readerToTestReread.result)

Why is this check being added to this test testReadAgainAfterFailedReadStep1?
Why not adding a new async test case like testResultBeforeRead?