[webkit-reviews] review denied: [Bug 86882] [chromium] Make sure that render surfaces are not pixel doubled with a device scale factor of 2 : [Attachment 143627] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 29 21:49:40 PDT 2012


James Robinson <jamesr at chromium.org> has denied vollick at chromium.org's request
for review:
Bug 86882: [chromium] Make sure that render surfaces are not pixel doubled with
a device scale factor of 2
https://bugs.webkit.org/show_bug.cgi?id=86882

Attachment 143627: Patch
https://bugs.webkit.org/attachment.cgi?id=143627&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
Keep in mind render surfaces can be whatever size we want - they're an
artificial intermediate we use and so long as we apply the correct scales they
can be any size we want.  We want going through an intermediate render surface
to be as lossless a process as we can afford, so it sounds reasonable that on a
pixel-doubled device a viewport-sized layer should have a width/height of twice
the CSS pixel width/height of the layer.  It's less obvious to me how page
scale on a layer should impact the render surface size.  If there's a case
where we should be changing the RS size based on page scale, would someone mind
drawing up a brief diagram of how that should interact?


More information about the webkit-reviews mailing list