[webkit-reviews] review granted: [Bug 87623] comparePositions in htmlediting should consider nested Shadow DOM. : [Attachment 144689] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 87623: comparePositions in htmlediting should consider nested Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87623

Attachment 144689: Patch
https://bugs.webkit.org/attachment.cgi?id=144689&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144689&action=review


This is a great improvement if it passes all the tests.

> Source/WebCore/dom/TreeScope.cpp:268
> +    if (treeScopesA[indexA] == treeScopesB[indexB])
> +	   return treeScopesA[indexA];
> +
> +    return 0;

Maybe use ternary operator here?