[webkit-reviews] review denied: [Bug 87811] correct the sequence of diagnostic crash check : [Attachment 144678] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 29 21:00:04 PDT 2012
James Robinson <jamesr at chromium.org> has denied Lu Guanqun
<guanqun.lu at intel.com>'s request for review:
Bug 87811: correct the sequence of diagnostic crash check
https://bugs.webkit.org/show_bug.cgi?id=87811
Attachment 144678: Patch
https://bugs.webkit.org/attachment.cgi?id=144678&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
I think you slightly misunderstand the meaning of the tileAt() check - we're
trying to verify that _after_ adding the tile it exists. Moving the CHECK()
for addedTile seems reasonable.
More information about the webkit-reviews
mailing list