[webkit-reviews] review granted: [Bug 87556] The difference between a column and a column group renderer is badly drawn : [Attachment 144674] Proposed fix 2: With the crasher?

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 87556: The difference between a column and a column group renderer is badly
drawn
https://bugs.webkit.org/show_bug.cgi?id=87556

Attachment 144674: Proposed fix 2: With the crasher?
https://bugs.webkit.org/attachment.cgi?id=144674&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144674&action=review


Looks like you are accidently changing a acid3 png ? can you check.

> Source/WebCore/editing/htmlediting.cpp:379
> +    return (renderer && (renderer->isTableCell() || renderer->isTableRow()
|| renderer->isTableSection() || renderer->isRenderTableCol()));

Do we want to use isTablePart here ?

> Source/WebCore/rendering/AutoTableLayout.cpp:173
> +	   if (column->isTableColumn() && !column->nextSibling())

What guarantees that our parent is a column group. can this not be an
independent table column without being enclosed in column group. Original code
does a parent check for isTableCol before changing groupLogicalWidth ?