[webkit-reviews] review denied: [Bug 87154] Make the files attribute of HTMLInputElement writable : [Attachment 144680] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Nico Weber
<thakis at chromium.org>'s request for review:
Bug 87154: Make the files attribute of HTMLInputElement writable
https://bugs.webkit.org/show_bug.cgi?id=87154

Attachment 144680: Patch
https://bugs.webkit.org/attachment.cgi?id=144680&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144680&action=review


> Source/WebCore/bindings/objc/PublicDOMInterfaces.h:629
> +#if WEBKIT_VERSION_MIN_REQUIRED >= WEBKIT_VERSION_LATEST
> + at property(retain) DOMFileList *files;
> +#else
>  @property(readonly, retain) DOMFileList *files
AVAILABLE_IN_WEBKIT_VERSION_4_0;
> +#endif

#ifdefs in this file are not correct. This file is parsed by a build script and
not used by a compiler. In this case it is file to just drop the readonly and
keep the AVAILABLE_IN_WEBKIT_VERSION_4_0.