[webkit-reviews] review denied: [Bug 64201] Composited fixed position layers have an incorrect overlap map entry : [Attachment 144633] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Adrienne Walker <enne at google.com>'s
request for review:
Bug 64201: Composited fixed position layers have an incorrect overlap map entry
https://bugs.webkit.org/show_bug.cgi?id=64201

Attachment 144633: Patch
https://bugs.webkit.org/attachment.cgi?id=144633&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144633&action=review


I see no changes in this patch that should have any effect. The new code does
the same thing the old code did, just in a slightly different way. Do these
tests fail without the bug fix? How do they fail? What exactly was wrong with
the old code?

> Source/WebCore/ChangeLog:31
> +2012-05-25  Adrienne Walker	<enne at google.com>
> +
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Test: compositing/layer-creation/fixed-position-overlap.html
> +
> +	   * rendering/RenderGeometryMap.cpp:
> +	   (WebCore::RenderGeometryMap::absoluteRect):
> +	   (WebCore::RenderGeometryMap::mapToAbsolute):
> +

Doubled change log entry.

> LayoutTests/ChangeLog:32
> +2012-05-25  Adrienne Walker	<enne at google.com>
> +
> +	   Composited fixed position layers have an incorrect overlap map entry

> +	   https://bugs.webkit.org/show_bug.cgi?id=64201
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * compositing/layer-creation/fixed-position-overlap-expected.txt:
Added.
> +	   * compositing/layer-creation/fixed-position-overlap.html: Added.
> +

Doubled entry here too.