[webkit-reviews] review granted: [Bug 87717] Unresponsive WebProcesses can be mistaken for crashes. : [Attachment 144497] patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Stephanie Lewis
<slewis at apple.com>'s request for review:
Bug 87717: Unresponsive WebProcesses can be mistaken for crashes.
https://bugs.webkit.org/show_bug.cgi?id=87717

Attachment 144497: patch
https://bugs.webkit.org/attachment.cgi?id=144497&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144497&action=review


The patch looks fine. I'm not sure how you're defining "unresponsive" in
WebKit2, but does it make sense to map these things onto TIMEOUTs rather than
CRASHes?

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:588
> +	       crash_log += '  Process failed to become responsive before
timing out.'

See my comment in bug 87714 about possibly changing the interface to
_get_crash_log() so that you don't have to do the .startswith() check here.