[webkit-reviews] review granted: [Bug 87276] IndexedDB: Align codes and names for IDB-specific and DOM-specific errors/exceptions : [Attachment 144582] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 87276: IndexedDB: Align codes and names for IDB-specific and DOM-specific
errors/exceptions
https://bugs.webkit.org/show_bug.cgi?id=87276

Attachment 144582: Patch
https://bugs.webkit.org/attachment.cgi?id=144582&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144582&action=review


> Source/WebCore/Modules/indexeddb/IDBDatabaseException.cpp:45
> +    { "NonTransientError", "NonTransientError", 0 }, // FIXME: No longer in
the spec
> +    { 0, 0, 0 }, // FIXME: Previous/legacy value NOT_FOUND_ERR.

Keeping parallel arrays seems fragile.	Are there plans to move away from this?
 E.g., maybe we could use a map or a static sized array where we assign each
entry based on the enum values.