[webkit-reviews] review denied: [Bug 87094] GeneratorGeneratedImage should cache images for no pattern draw : [Attachment 143752] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 29 10:16:53 PDT 2012
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jin Yang
<jin.a.yang at intel.com>'s request for review:
Bug 87094: GeneratorGeneratedImage should cache images for no pattern draw
https://bugs.webkit.org/show_bug.cgi?id=87094
Attachment 143752: Patch
https://bugs.webkit.org/attachment.cgi?id=143752&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143752&action=review
> Source/WebCore/ChangeLog:8
> + No new tests.Performance optimization.
Missing space. You need some explanation of the change in the changlog here.
> Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp:55
> + // Tile the image buffer to the destination
This is the untiled case, so this comment is inaccurate.
More information about the webkit-reviews
mailing list