[webkit-reviews] review granted: [Bug 87223] [Shadow DOM] Node distribution should be orthogonal from node attachment : [Attachment 144436] Fixing win build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 29 10:01:57 PDT 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 87223: [Shadow DOM] Node distribution should be orthogonal from node
attachment
https://bugs.webkit.org/show_bug.cgi?id=87223

Attachment 144436: Fixing win build
https://bugs.webkit.org/attachment.cgi?id=144436&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144436&action=review


This is a much cleaner design! I looked over the code a few times, and it seems
to be workable. Let's give it a spin.

> Source/WebCore/ChangeLog:14
> +	   This change extracts these code to a set of ContentDistributor
methods, which are

"these code" is awkward. Maybe "these bits of code"?

> Source/WebCore/ChangeLog:30
> +	   Here is such DOM mutations:

"Here are"


More information about the webkit-reviews mailing list