[webkit-reviews] review denied: [Bug 87684] Implement post-landing feedback for WebKitCSSTransformValue::customCSSText(). : [Attachment 144411] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 87684: Implement post-landing feedback for
WebKitCSSTransformValue::customCSSText().
https://bugs.webkit.org/show_bug.cgi?id=87684

Attachment 144411: Patch
https://bugs.webkit.org/attachment.cgi?id=144411&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144411&action=review


>> Source/WebCore/css/WebKitCSSTransformValue.cpp:36
>> +const char* const transformName[22] = {
> 
> I think the idea was to get rid of this "22" as well, and use "const char*
const transformName[] = { ...".
> 
> I also think it is a good idea to point out that this needs to be
synchronized with TransformOperationType enum.

Agreed on both points.