[webkit-reviews] review granted: [Bug 87004] [Meta] Refactor ComposedShadowTreeWalker : [Attachment 144305] refactor a walker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 29 09:42:45 PDT 2012


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 87004: [Meta] Refactor ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=87004

Attachment 144305: refactor a walker
https://bugs.webkit.org/attachment.cgi?id=144305&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144305&action=review


> Source/WebCore/ChangeLog:3
> +	   Introcues ComposedShadowTreeParentWalker, extracted from
ComposedShadowTreeWalker.

Introcues -> Introduces

> Source/WebCore/dom/ComposedShadowTreeWalker.h:124
> +    void parentIncludingInsertionPointAndShadowRoot();

If this is a specialized walker, why not just call this "parent"?


More information about the webkit-reviews mailing list