[webkit-reviews] review denied: [Bug 87658] [Gtk] Add support in DumpRenderTree for tracking repaints : [Attachment 144350] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 87658: [Gtk] Add support in DumpRenderTree for tracking repaints
https://bugs.webkit.org/show_bug.cgi?id=87658

Attachment 144350: Patch
https://bugs.webkit.org/attachment.cgi?id=144350&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144350&action=review


Looks good though I think it makes sense to include pixel results with this
patch. r- only because I'd like to take a look at the pixel results to manually
verify the correctness.

> Tools/DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:41
> +    cairo_set_source_rgba(context, 0.0, 0.0, 0.0, 0.66);

It makes sense to include a comment about where these numbers come from.

> Tools/DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:90
> +	   cairo_surface_t* overlaySurface =
cairo_image_surface_create(CAIRO_FORMAT_ARGB32, width, height);
> +	   paintOverlay(overlaySurface);
> +
> +	   cairo_set_source_surface(context, overlaySurface, 0, 0);
> +	   cairo_rectangle(context, 0, 0, width, height);
> +	   cairo_fill(context);
> +
> +	   cairo_surface_destroy(overlaySurface);

I think it'd be nice to split out this code into another helper as well.