[webkit-reviews] review canceled: [Bug 87283] [GTK] run-file-chooser signal for WebKit1 : [Attachment 144053] run-file-chooser ready for review

[bugzilla-daemon at webkit.org]

Daniel Drake <dsd at laptop.org> has canceled Daniel Drake <dsd at laptop.org>'s
request for review:
Bug 87283: [GTK] run-file-chooser signal for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=87283

Attachment 144053: run-file-chooser ready for review
https://bugs.webkit.org/attachment.cgi?id=144053&action=review

------- Additional Comments from Daniel Drake <dsd at laptop.org>
Thanks! Here's a new patch addressing those comments.

If there is not much focus on making WebKit1 and WebKit2 gobject APIs similar,
I agree with removing the cancel method (done in the patch).

The one remaining issue I have here is that it complains during build:

/home/dsd/projects/WebKit-r118336/Source/WebKit/gtk/webkit/webkitfilechooserreq
uest.cpp:56: warning: Section WebKitFileChooserRequest is not defined in the
webkitgtk-section.txt file.

Does it mean webkitgtk-sections.txt (with an 's')? I do have an entry there,
and I can't see what I'm doing differently compared to other classes. Either
way it does not seem to affect the functionality.