[webkit-reviews] review granted: [Bug 87735] [Chromium] [Regression] SELECT popup misplaced when there is not enough vertical space : [Attachment 144538] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 87735: [Chromium] [Regression] SELECT popup misplaced when there is not
enough vertical space
https://bugs.webkit.org/show_bug.cgi?id=87735

Attachment 144538: Patch
https://bugs.webkit.org/attachment.cgi?id=144538&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144538&action=review


ok

> Source/WebCore/ChangeLog:10
> +	   No new tests, as popups are not testable in Chromium.

Right.

Let's consider to introduce a unit test for the rect calculation later.