[webkit-reviews] review granted: [Bug 87655] Web Inspector: Retainers are missing for all objects : [Attachment 144529] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 87655: Web Inspector: Retainers are missing for all objects
https://bugs.webkit.org/show_bug.cgi?id=87655

Attachment 144529: Patch
https://bugs.webkit.org/attachment.cgi?id=144529&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144529&action=review


> LayoutTests/inspector/profiler/heap-snapshot-test.js:341
> +InspectorTest.clickRow = function(row, callback)

The method should have more specific name reflecting that it will pass
retainers root to the callback.

> LayoutTests/inspector/profiler/heap-snapshot-test.js:355
> +	   setTimeout(function() { callback(rootNode); }, 0);

Why do you need this setTimeout ?