[webkit-reviews] review denied: [Bug 87725] GraphicsSurface: allow importing and exporting of textures directly on GPU side. : [Attachment 144508] patch for review.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 87725: GraphicsSurface: allow importing and exporting of textures directly
on GPU side.
https://bugs.webkit.org/show_bug.cgi?id=87725

Attachment 144508: patch for review.
https://bugs.webkit.org/attachment.cgi?id=144508&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144508&action=review


Good direction, let's fix the nitpicks :)

> Source/WebCore/platform/graphics/surfaces/GraphicsSurface.cpp:49
> +uint32_t GraphicsSurface::exportTexture()

Let's call it getTextureID(). export is for cross-process sharing.

>> Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h:69
>> +	uint32_t exportTexture();
> 
> What does the exportToken do? Isn't it also like a texture id ?

exportToken is a cross-process number that can mean anything.