[webkit-reviews] review granted: [Bug 87693] [GStreamer] Video sink doesn't respect WebKit code style : [Attachment 144444] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 29 04:11:58 PDT 2012


Alexis Menard (darktears) <alexis.menard at openbossa.org> has granted Philippe
Normand <pnormand at igalia.com>'s request for review:
Bug 87693: [GStreamer] Video sink doesn't respect WebKit code style
https://bugs.webkit.org/show_bug.cgi?id=87693

Attachment 144444: Patch
https://bugs.webkit.org/attachment.cgi?id=144444&action=review

------- Additional Comments from Alexis Menard (darktears)
<alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144444&action=review


Other that the comment rs=me

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:42
> +static GstStaticPadTemplate sinkTemplate = GST_STATIC_PAD_TEMPLATE("sink",
GST_PAD_SINK, GST_PAD_ALWAYS, GST_STATIC_CAPS(WEBKIT_VIDEO_SINK_PAD_CAPS));

The static variable should start with s_ isn't it?


More information about the webkit-reviews mailing list