[webkit-reviews] review granted: [Bug 87709] File.lastModifiedDate must return null if the modified time info is not available : [Attachment 144484] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 87709: File.lastModifiedDate must return null if the modified time info is
not available
https://bugs.webkit.org/show_bug.cgi?id=87709

Attachment 144484: Patch
https://bugs.webkit.org/attachment.cgi?id=144484&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144484&action=review


>>> Source/WebCore/ChangeLog:10
>>> +	     http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate
>> 
>> What's the behavior of other browsers?
> 
> Safari 5.1 behaves in the same way as the current chrome does (i.e. returns
"Jan 01 1970" date/time if unavailable), and as far as I checked FireFox/IE
don't support it yet.
> [Some more note: there's ongoing discussion to make 'lastModifiedDate'
attribute static, and in that case this test will become invalid as we will be
returning the same date/time without querying (I'll deprecate this test then),
but the change itself should remain valid since there will still be a chance
where 'lastModifiedDate' is not available when we capture file metadata]

Thank you very much for the clarification. The change looks reasonable.