[webkit-reviews] review requested: [Bug 87558] Some Content Security Policy console messages are missing line numbers in JSC : [Attachment 144493] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 29 02:36:25 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 87558: Some Content Security Policy console messages are missing line
numbers in JSC
https://bugs.webkit.org/show_bug.cgi?id=87558

Attachment 144493: Patch
https://bugs.webkit.org/attachment.cgi?id=144493&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
The found the difference between JSC and V8 implementations of
ScriptController::eventHandlerPosition(). Making JSC implementation behave as
the V8 one fixes the line printing issue (because the function returns line 1
instead of line 0 in those cases). The patch does not seem to cause any
regression for me.


More information about the webkit-reviews mailing list