[webkit-reviews] review granted: [Bug 87650] Remove m_rootNode and m_selectorChecker from SelectorQuery.h : [Attachment 144332] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 87650: Remove m_rootNode and m_selectorChecker from SelectorQuery.h
https://bugs.webkit.org/show_bug.cgi?id=87650

Attachment 144332: Patch
https://bugs.webkit.org/attachment.cgi?id=144332&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=144332&action=review


>> Source/WebCore/ChangeLog:9
>> +	    Remove m_rootNode and m_selectorChecker from SelectorQuery.h
>> +	    https://bugs.webkit.org/show_bug.cgi?id=87650
>> +
>> +	    Reviewed by NOBODY (OOPS!).
>> +
>> +	    This is a refactoring patch for upcoming optimization.
>> +	    We can remove m_rootNode and m_selectorChecker from
SelectorQuery.h.
> 
> Where are are you heading with this? An obvious optimization direction would
be caching SelectorQuery objects but this would make it less effective.

You should explain in the ChangeLog why this change is helpful for future
optimizations.