[webkit-reviews] review granted: [Bug 87702] Add readDirectory command and didReadDirectory event to InspectorFileSystemAgent : [Attachment 144461] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 87702: Add readDirectory command and didReadDirectory event to
InspectorFileSystemAgent
https://bugs.webkit.org/show_bug.cgi?id=87702

Attachment 144461: Patch
https://bugs.webkit.org/attachment.cgi?id=144461&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144461&action=review


> Source/WebCore/inspector/Inspector.json:1420
> +		       { "name": "errorCode", "type": "integer" },

Please add a description for this and the next fields.

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:80
> +    m_frontend->didReadDirectory(requestId,
static_cast<int>(FileError::ABORT_ERR), TypeBuilder::Array<String>::create());

You may want to make the "entries" field optional as it makes no sense in case
of an error.