[webkit-reviews] review granted: [Bug 87497] Web Inspector: Tabbed Settings Screen : [Attachment 144448] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 87497: Web Inspector: Tabbed Settings Screen
https://bugs.webkit.org/show_bug.cgi?id=87497

Attachment 144448: Patch
https://bugs.webkit.org/attachment.cgi?id=144448&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144448&action=review


> Source/WebCore/inspector/front-end/SettingsScreen.js:639
> +WebInspector.SettingsScreen.SettingsTab = "settings";

WebInspector.SettingsScreen.Tabs = {
  Settings: "Settings",
  Shortcuts: "Shortcuts"
}
like we do with constants in other places.

> Source/WebCore/inspector/front-end/SettingsScreen.js:645
> + * @extends {WebInspector.TabbedPane}

@extends should go right after @constructor, the general rule is to mind
alphabetic order of @<name>