[webkit-reviews] review denied: [Bug 87623] comparePositions in htmlediting should consider nested Shadow DOM. : [Attachment 144329] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 28 21:57:40 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 87623: comparePositions in htmlediting should consider nested Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87623

Attachment 144329: Patch
https://bugs.webkit.org/attachment.cgi?id=144329&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144329&action=review


> LayoutTests/editing/shadow/compare-positions-in-nested-shadow.html:20
> +// Returns div in nested Shadow DOM.

This comment repeats what the code does. Please remove.

> LayoutTests/editing/shadow/compare-positions-in-nested-shadow.html:27
> +    var darkRoot = new WebKitShadowRoot(div);
> +    var darkDiv = document.createElement('div');

Why don't we just call this nestedShadowRoot?

> LayoutTests/editing/shadow/compare-positions-in-nested-shadow.html:38
> +var div1 = results1[2];
> +var div2 = results2[2];

It would read better if createNestedShadowDOM just returned the nested shadow
root instead of returning 3-tuple
since you can get other nodes by calling methods.


More information about the webkit-reviews mailing list