[webkit-reviews] review denied: [Bug 87383] [WebSocket] Send requires super linear time against data size : [Attachment 144284] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 87383: [WebSocket] Send requires super linear time against data size
https://bugs.webkit.org/show_bug.cgi?id=87383

Attachment 144284: Patch
https://bugs.webkit.org/attachment.cgi?id=144284&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144284&action=review


> Source/WTF/wtf/StreamBuffer.h:50
> +    }
> +    ~StreamBuffer()

nit: Please add a blank line between function definitions.

> Source/WTF/wtf/StreamBuffer.h:54
> +    }
> +    bool isEmpty() const { return !size(); }
> +    void append(const T* data, size_t size)

ditto.

> Source/WTF/wtf/StreamBuffer.h:63
> +		   OwnPtr<Block> block = adoptPtr(new Block);
> +		   m_buffer.append(block.release());

nit: You can omit the variable 'block'.

> Source/WTF/wtf/StreamBuffer.h:75
> +    }
> +    void consume(size_t size)

Please add a blank line.
We should add a comment that we can't specify size which is >=
firstBlockSize().

> Source/WTF/wtf/StreamBuffer.h:81
> +	   if (m_readOffset == BlockSize) {

We had better use >= for safety.

> Source/WTF/wtf/StreamBuffer.h:87
> +    }
> +    size_t size() const { return m_size; }
> +    const T* firstBlockData() const

Please add blank lines.

> Source/WTF/wtf/StreamBuffer.h:93
> +    }
> +    size_t firstBlockSize() const

Please add a blank line.

> Source/WebCore/platform/network/SocketStreamHandleBase.cpp:2
> - * Copyright (C) 2009, 2011 Google Inc.  All rights reserved.
> + * Copyright (C) 2012 Google Inc.  All rights reserved.

We don't replace existing years in WebKit.

> Source/WebCore/platform/network/SocketStreamHandleBase.h:3
> - * Copyright (C) 2009 Google Inc.  All rights reserved.
> + * Copyright (C) 2012 Google Inc.  All rights reserved.

ditto.