[webkit-reviews] review requested: [Bug 87687] Check for GTK2/GTK3 symbol mismatch earlier : [Attachment 144423] patch

[bugzilla-daemon at webkit.org]

Daniel Drake <dsd at laptop.org> has asked  for review:
Bug 87687: Check for GTK2/GTK3 symbol mismatch earlier
https://bugs.webkit.org/show_bug.cgi?id=87687

Attachment 144423: patch
https://bugs.webkit.org/attachment.cgi?id=144423&action=review

------- Additional Comments from Daniel Drake <dsd at laptop.org>
WebKit2 move plugins into their own process, but WebKit1 (built for GTK3) is
left with the limitation that if a plugin links against GTK2, it will fail to
run.

nspluginwrapper could maybe work around this issue, by adding in a process
separation, but this doesn't work on current released WebKit. The affected
sites just show an empty box where the content should be.

Using Flash as an example, I dug down and found that the behaviour is something
like the following:
 - Load both "real" libflashplayer and the wrapped libflashplayer
 - Try to show the flash content using the real libflashplayer
 - Abort because a mix of GTK2/GTK3 symbols was detected

And that's it - it didn't even try the wrapped libflashplayer which advertises
support for the same mime types.

I found a way to fix this: Move the GTK2/GTK3 symbol check earlier, and don't
even register plugins in the PluginDatabase if there is a symbol mismatch. See
attached patch.

With this patch applied, I can finally view flash content in recent Epiphany
versions, via nspluginwrapper!