[webkit-reviews] review granted: [Bug 42328] WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled : [Attachment 144347] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Jesus Sanchez-Palencia
<jesus at webkit.org>'s request for review:
Bug 42328: WebKitTestRunner needs to support
layoutTestController.setJavaScriptProfilingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42328

Attachment 144347: Patch
https://bugs.webkit.org/attachment.cgi?id=144347&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144347&action=review


Seems reasonable.

> Source/WebCore/testing/InternalSettings.cpp:105
> +    , m_originalJavaScriptProfilingEnabled((page() &&
page()->inspectorController()) ?
page()->inspectorController()->profilerEnabled() : false)

This could be an && instead of a ternary.