[webkit-reviews] review granted: [Bug 80135] [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail : [Attachment 144364] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 80135: [BlackBerry] http authenticate dialog popup only once no matter
authentication pass or fail
https://bugs.webkit.org/show_bug.cgi?id=80135

Attachment 144364: Patch
https://bugs.webkit.org/attachment.cgi?id=144364&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144364&action=review


Looks good but please fix my issues before landing.

> Source/WebCore/ChangeLog:9
> +	   issue for BlackBerry porting get identified and fixed.

It is better to keep the original ChangeLog messages. Or keep them and append
these two lines too.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:130
> +    return "<unknown>";

This needs to be implemented? If so add a TODO.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:877
> +    return true;

Is this tested? Do you think we will need to change some test results?