[webkit-reviews] review granted: [Bug 87569] [BlackBerry] Add a default tap highlight : [Attachment 144231] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Arvid Nilsson <anilsson at rim.com>'s
request for review:
Bug 87569: [BlackBerry] Add a default tap highlight
https://bugs.webkit.org/show_bug.cgi?id=87569

Attachment 144231: Patch
https://bugs.webkit.org/attachment.cgi?id=144231&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144231&action=review


Looks good.

> Source/WebKit/blackberry/Api/WebTapHighlight.h:33
> +    virtual void draw(const Platform::IntRectRegion&, int red, int green,
int blue, int alpha, bool hideAfterScroll) = 0;

Have you considered RGBA32?

> Source/WebKit/blackberry/WebKitSupport/DefaultTapHighlight.cpp:37
> +#include <SkCornerPathEffect.h>

Is this one needed?