[webkit-reviews] review granted: [Bug 87349] REGRESSION(r96517): Attribute selector fails to match dynamically modified style attribute : [Attachment 144374] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 28 09:09:05 PDT 2012


Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 87349: REGRESSION(r96517): Attribute selector fails to match dynamically
modified style attribute
https://bugs.webkit.org/show_bug.cgi?id=87349

Attachment 144374: patch
https://bugs.webkit.org/attachment.cgi?id=144374&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144374&action=review


> Source/WebCore/css/SelectorChecker.cpp:407
> +	   // Style attribute is generated lazily but the fast path doesn't do
trigger that.

This comment doesn't do English :(

> LayoutTests/fast/css/dynamic-style-attribute-query.html:12
> +document.addEventListener("DOMContentLoaded", test , false);

Silly space after 'test'.


More information about the webkit-reviews mailing list