[webkit-reviews] review granted: [Bug 87565] [BlackBerry] Update WebPageCompositor::render() API : [Attachment 144228] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Arvid Nilsson <anilsson at rim.com>'s
request for review:
Bug 87565: [BlackBerry] Update WebPageCompositor::render() API
https://bugs.webkit.org/show_bug.cgi?id=87565

Attachment 144228: Patch
https://bugs.webkit.org/attachment.cgi?id=144228&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=144228&action=review


Looks good.

> Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:321
> +	   return;

Could combine with above if.

> Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:325
> +    for (size_t i = 0; i < sublayers.size(); i++) {

might want to stick to always using ++i or i++, now it is inconsistent.

> Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:326
> +	   float opacity = 1;

I am not sure this extra var is needed.