[webkit-reviews] review canceled: [Bug 87245] [EFL] Ewk_Intent does not expose WebCore::Intent::data() : [Attachment 144351] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <christophe.dumez at intel.com> has canceled Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 87245: [EFL] Ewk_Intent does not expose WebCore::Intent::data()
https://bugs.webkit.org/show_bug.cgi?id=87245

Attachment 144351: Patch
https://bugs.webkit.org/attachment.cgi?id=144351&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Clearing flags. I'll provide the wire string code for
JSC::SerializedScriptValue in a separate patch and not use it for the EFL
Intent code. Instead, I plan to write an EFL wrapper for SerializedScriptValue
(similar to WebSerializedScriptValue).

Relying on the internal representation of the WTF::String in the EFL Intent
code is unsafe, especially considering JSC and V8 implementations of
SerializedScriptValue use different representations (JSC uses 8bit, V8 appears
to be using 16-Bit).