[webkit-reviews] review denied: [Bug 87627] [Performance] Optimize querySelector() and querySelectorAll() by removing redundant dummy style sheet creations : [Attachment 144324] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 87627: [Performance] Optimize querySelector() and querySelectorAll() by
removing redundant dummy style sheet creations
https://bugs.webkit.org/show_bug.cgi?id=87627

Attachment 144324: Patch
https://bugs.webkit.org/attachment.cgi?id=144324&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=144324&action=review


> Source/WebCore/ChangeLog:83
> +	   - We do not need to construct a CSSParser every time. This patch
caches
> +	   the CSSParser on Document, by which we can remove the CSSParser
constructor
> +	   from querySelector() and querySelectorAll().

This may be problematic as we grab bunch of settings and state from the
document on CSSParser construction. If those change the cached parser instance
will need to be invalidated. The cached instance could also be used more widely
than just querySelector.

I think this part should be done in a separate patch. Lets focus on avoiding
dummy stylesheet construction here.