[webkit-reviews] review granted: [Bug 87635] Web Inspector: Add InspectorFileSystemAgent::FrontendProvider : [Attachment 144331] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 28 05:13:58 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 87635: Web Inspector: Add InspectorFileSystemAgent::FrontendProvider
https://bugs.webkit.org/show_bug.cgi?id=87635

Attachment 144331: Patch
https://bugs.webkit.org/attachment.cgi?id=144331&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=144331&action=review


> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:82
> +    if (m_frontendProvider.get())

No need for .get(), if (m_frontendProvider) should work

> Source/WebCore/inspector/InspectorFileSystemAgent.cpp:111
> +    if (m_frontendProvider.get()) {

if (m_frontendProvider.get()) { -> if (m_frontendProvider) {


More information about the webkit-reviews mailing list